[PATCH] D61237: [SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold doesn't trigger

[James Molloy via Phabricator via llvm-commits]

jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits. Thanks!



================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:5578
+
+  // We Xor against Values[any] because the if we do not start at zero,
+  // but also don't meet the SubThreshold, then we still might share
----------------
Values[any] -> Values[BestIndex]?


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:5592
 
+  // ...then we should insert the subtraction anyways, because the rotate trick
+  // below to avoid a branch needs the shifted away bits to be zero.
----------------
I don't think this comment serves any purpose split. Just cat it onto the end of the ... above, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61237/new/

https://reviews.llvm.org/D61237