[PATCH] D61158: [SimplifyCFG] use fshr instead of shl/lshr/or

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 01:07:28 PDT 2019


jmolloy added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:5587
+    auto *ShiftC = ConstantInt::get(Ty, Shift);
+    Function *Fshr = Intrinsic::getDeclaration(SI->getModule(), Intrinsic::fshr, Ty);
+    Key = Builder.CreateCall(Fshr, {Key, Key, ShiftC}, "switch.rangereduce");
----------------
I still don't agree with using fshr here; I've given you my rationale before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61158/new/

https://reviews.llvm.org/D61158





More information about the llvm-commits mailing list