[PATCH] D60846: [ValueTracking] Improve isKnowNonZero for Ints

Mon Apr 29 00:28:20 PDT 2019

nikic added a comment.

In D60846#1481903 <https://reviews.llvm.org/D60846#1481903>, @dlrobertson wrote:

> In D60846#1481782 <https://reviews.llvm.org/D60846#1481782>, @spatel wrote:
>
> > In D60846#1481774 <https://reviews.llvm.org/D60846#1481774>, @nikic wrote:
> >
> > > test/Transforms/LICM/hoist-mustexec.ll still needs to be updated. (Should probably generate full checks as a preliminary NFC commit first.)
> >
> >
> > Oops - I forgot that even though I mentioned it in the earlier comment. Yes, that must be included in this patch (and any other existing tests that are known to be affected).
>
>
> Sorry, I forgot all about this as well. I did run the `update_test_checks` script on this file after applying the patch and there was not improvement to the generated code.

Are you sure? I didn't check what exactly changed, but this test was failing for me locally after applying the patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60846/new/

https://reviews.llvm.org/D60846