[PATCH] D60294: [DAGCombiner] [CodeGenPrepare] Split large offsets from base addresses

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: test/CodeGen/SystemZ/int-sub-05.ll:58
 ; CHECK-LABEL: f4:
-; CHECK: lgr [[BASE:%r[1-5]]], %r2
-; CHECK: agfi [[BASE]], 524288
-; CHECK: slg {{%r[0-5]}}, 0([[BASE]])
+; CHECK: lay [[BASE:%r[0-5]]], 524280(%r2)
+; CHECK: slg {{%r[0-5]}}, 8([[BASE]])
----------------
luismarques wrote:
> uweigand wrote:
> > Should be %r[1-5] here as well, register 0 cannot be used for address generation.   Otherwise, the SystemZ changes LGTM now.  Thanks!
> Oops. Thanks!
Perfect, thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60294/new/

https://reviews.llvm.org/D60294