[PATCH] D61202: [AMDGPU] gfx1010 VOP3 and VOP3P implementation

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 10:50:27 PDT 2019


kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/AMDGPU/VOP3Instructions.td:771
+  VOP3OpSel_Real_gfx10_with_name<0x340, "V_MAD_U16_gfx9", "v_mad_u16">;
+// FIXME-GFX10-V_FMA_F16: GFX10's V_FMA_F16 should be really matched to
+// V_FMA_F16_gfx9 because it has opsel. Currently if we match to V_FMA_F16_gfx9,
----------------
IIRC it is already fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61202/new/

https://reviews.llvm.org/D61202





More information about the llvm-commits mailing list