[PATCH] D59431: [DebugInfo] Terminate more kinds of location-list ranges at the end of basic blocks

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I think I'm mostly fin with this now, thanks!



================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:367
+          assert(Ent.isDbgValue() && !Ent.isClosed());
+          const MachineInstr *DMI = Ent.getInstr();
+
----------------
DMI -> DbgValue ?


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:372
+          // to keep LiveEntries iteration stable.
+          if (DMI->getOperand(0).isReg()) {
+            unsigned RegNo = DMI->getOperand(0).getReg();
----------------
This comment is sort of misleading because your test also triggers for values where isIndirectDebugValue() is true. I think the code does what you want, but the condition also triggers for register-indirect values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59431/new/

https://reviews.llvm.org/D59431