[PATCH] D61055: [LoopSimplifyCFG] Suppress expensive DomTree verification in LoopSimplifyCFG

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 13:40:28 PDT 2019


kuhar added a comment.

In D61055#1481841 <https://reviews.llvm.org/D61055#1481841>, @dmgreen wrote:

> But I was not aware that Fast used to be the default, and was still quite slow. I was under the impression that the problems in the past were to do with it using Full under expensive checks, and that Fast was fairly quick (quick enough for an asserts build).


It of course depends on exactly location, but we found that Fast is generally not quick enough to be run during a typical loop pass (on large files, or loopy code from non-clang frontends). I claim that it's better to make it obvious that these checks are slow, and make developers either guard them with `EXEPNSIVE_CHECKS` or opt-in with Fast.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61055/new/

https://reviews.llvm.org/D61055





More information about the llvm-commits mailing list