[PATCH] D60960: [ConstantRange] Add makeExactNoWrapRegion()

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/ConstantRange.h:127
 
-  /// Return the exact range containing all X such that "X BinOpC Y" is
-  /// guaranteed not to wrap (overflow) for all Y in Other.
+  /// Produce the largest range containing all X such that "X BinOp Y" is
+  /// guaranteed not to wrap (overflow) for *all* Y in Other. However, there may
----------------
sanjoy wrote:
> Does this always return the *largest* such range?  (Just double-checking that this language is intentional.)
Yep, this is indeed the largest range. We have some tests to check that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60960/new/

https://reviews.llvm.org/D60960