[PATCH] D61055: [LoopSimplifyCFG] Suppress expensive DomTree verification in LoopSimplifyCFG

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 07:08:26 PDT 2019


yrouban added a comment.

In D61055#1481627 <https://reviews.llvm.org/D61055#1481627>, @dmgreen wrote:

> Hello. I think it's fine to always use DominatorTree::VerificationLevel::Fast, the others are more about checking that the DomTree construction code was correct. Fast will compare against a new tree, so for updates will check the the tree is correct.


may be we have to set //Fast// by default instead of //Full//?

  bool DominatorTreeBase<>::verify(VerificationLevel VL = VerificationLevel::Full) const {


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61055/new/

https://reviews.llvm.org/D61055





More information about the llvm-commits mailing list