[PATCH] D61178: caseFoldingDjbHash: simplify and make the US-ASCII fast path faster

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 27 08:30:47 PDT 2019


MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: llvm/trunk/lib/Support/DJB.cpp:61
+static Optional<uint32_t> fastCaseFoldingDjbHash(StringRef Buffer, uint32_t H) {
+  bool allASCII = true;
+  for (unsigned char C : Buffer) {
----------------
aprantl wrote:
> This should be `AllASCII` according to the LLVM style?
Fixed!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61178/new/

https://reviews.llvm.org/D61178





More information about the llvm-commits mailing list