[PATCH] D59531: [ELF] Produce multiple PT_NOTE segments as needed

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 18:36:42 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/multiple-notes.s:14
+.section .note2, "a", @note
+  .align 16
+  .quad 0
----------------
I'd like to see `.align 8` instead of `.align 16`. I think the emitters only create 4-byte and 8-byte aligned notes and their sizes are padded so that `size%align == 0`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59531/new/

https://reviews.llvm.org/D59531





More information about the llvm-commits mailing list