[PATCH] D61207: [ConstantRange] Add srem() support

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/unittests/IR/ConstantRangeTest.cpp:127
+    ConstantRange Exact = ConstantRange::getNonEmpty(Min, Max + 1);
+    if (CorrectnessOnly) {
+      EXPECT_TRUE(CR.contains(Exact));
----------------
Hm, i wonder if we can also check that the result
is exact when the ranges contain a single element?
Not sure if that would hold for the current implementations though.

I also wonder if some kind of a "precision" metric should be calculated,
e.g. `ConstantRange` returned range with 75 elements, and exhaustive test
returned range with 67 elements then let's say it's 67/75.
And then just average that metric over all the checked ranges.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61207/new/

https://reviews.llvm.org/D61207