[PATCH] D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 15:00:47 PDT 2019


aprantl added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1287
+// Determine what DebugLoc to use for each dbg.declare/inst pair that are
+// promoted to a dbg.value.
+static DebugLoc getDebugValueLoc(DbgVariableIntrinsic *DII, Instruction *Src) {
----------------
Should we add a comment that everything except the inlinedAt is basically unused and that we are only putting it there as a safety guard for other transformations?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59272/new/

https://reviews.llvm.org/D59272





More information about the llvm-commits mailing list