[compiler-rt] r359339 - [Sanitizer][Windows] Speculative fix for broken build on Windows

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 12:06:55 PDT 2019


Author: yln
Date: Fri Apr 26 12:06:55 2019
New Revision: 359339

URL: http://llvm.org/viewvc/llvm-project?rev=359339&view=rev
Log:
[Sanitizer][Windows] Speculative fix for broken build on Windows

Modified:
    compiler-rt/trunk/lib/asan/asan_win.cc

Modified: compiler-rt/trunk/lib/asan/asan_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_win.cc?rev=359339&r1=359338&r2=359339&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_win.cc (original)
+++ compiler-rt/trunk/lib/asan/asan_win.cc Fri Apr 26 12:06:55 2019
@@ -166,11 +166,16 @@ void InitializePlatformInterceptors() {
                            (LPCWSTR)&InitializePlatformInterceptors,
                            &pinned));
 
-  ASAN_INTERCEPT_FUNC(CreateThread);
+  // FIXME: ASAN_INTERCEPT_FUNC has some sanity checking that currently does
+  // not compile, i.e., it compares `(&CreateThread) != WRAP(&CreateThread)`,
+  // but the type of the interceptor does not match.
+  // ASAN_INTERCEPT_FUNC(CreateThread);
+  INTERCEPT_FUNCTION(CreateThread);
   ASAN_INTERCEPT_FUNC(SetUnhandledExceptionFilter);
 
 #ifdef _WIN64
-  ASAN_INTERCEPT_FUNC(__C_specific_handler);
+  // ASAN_INTERCEPT_FUNC(__C_specific_handler); // FIXME: same as above
+  INTERCEPT_FUNCTION(__C_specific_handler);
 #else
   ASAN_INTERCEPT_FUNC(_except_handler3);
   ASAN_INTERCEPT_FUNC(_except_handler4);




More information about the llvm-commits mailing list