[PATCH] D61188: [cmake] Fix error message in simulated VS version check

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop created this revision.
russell.gallop added reviewers: jfb, chandlerc.
russell.gallop added a project: LLVM.
Herald added subscribers: dexonsmith, mgorny.

[cmake] Fix error message on simulated VS version check

For clang-cl self hosts in VS2015 environment this was reporting: "Host
Clang must have at least -fms-compatibility-version=19.00.24213.1, your
version is 9.0.0".

This check fires as CMake detects the simulated environment as _MSC_VER
1900, which is truncated. This makes it less than the required
19.00.24213.1.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61188

Files:
  llvm/cmake/modules/CheckCompilerVersion.cmake


Index: llvm/cmake/modules/CheckCompilerVersion.cmake
===================================================================
--- llvm/cmake/modules/CheckCompilerVersion.cmake
+++ llvm/cmake/modules/CheckCompilerVersion.cmake
@@ -50,7 +50,7 @@
 if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   if (CMAKE_CXX_SIMULATE_ID MATCHES "MSVC")
     if (CMAKE_CXX_SIMULATE_VERSION VERSION_LESS MSVC_MIN)
-      message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_COMPILER_VERSION}.")
+        message(FATAL_ERROR "Host Clang must have at least -fms-compatibility-version=${MSVC_MIN}, your version is ${CMAKE_CXX_SIMULATE_VERSION}.")
     endif()
     set(CLANG_CL 1)
   elseif(NOT LLVM_ENABLE_LIBCXX)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61188.196844.patch
Type: text/x-patch
Size: 751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190426/7c9a346f/attachment.bin>