[PATCH] D61164: [X86] If PreprocessISelDAG reorders a load before a call, make sure we remove dead nodes from the graph

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 05:50:42 PDT 2019


niravd added a comment.

I worry this is just fix just the dangling nodes as we see them. A brief glance at the AND construction gives us space for this to happen again. I'd much rather we do the removal check unconditionally or leverage something like 
DAGUpdateListener to get a more fundamental measure of what nodes may be prunable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61164/new/

https://reviews.llvm.org/D61164





More information about the llvm-commits mailing list