[PATCH] D58484: [DO NOT SUBMIT] Add -vs-diagnostics.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 04:11:57 PDT 2019


MaskRay added inline comments.


================
Comment at: Common/ErrorHandler.cpp:89
+static std::string getLocation(std::string Msg, std::string Default) {
+  static std::vector<std::regex> Regexes{
+      std::regex(
----------------
How about using `llvm::Regex` instead of `std::regex`. I assume that may make the increased code size smaller.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58484/new/

https://reviews.llvm.org/D58484





More information about the llvm-commits mailing list