[PATCH] D60825: [llvm-objcopy] - Check dynamic relocation sections for broken references.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 01:29:44 PDT 2019


grimar added a comment.

In D60825#1479436 <https://reviews.llvm.org/D60825#1479436>, @jakehehrlich wrote:

> Maybe we should land this and wait for someone to have that issue. Can someone file a bug about that issue now?


Right now we already have a bug saying that "If you strip a section that is referred to by a dynamic relocation section (e.g. the .dynsym),
llvm-objcopy lets it happen assuming that there are no other references".
(https://bugs.llvm.org/show_bug.cgi?id=41371)

As far I understand, after changing the behavior, we might want to post a bug saying something like the following, right?
"Currently when  --allow-broken-links is *not* given we always report a error when removing a symbol table used by a dynamic relocation section.
Though it should be possible to do that only in a case when we know that using symbols from dynamic symbol table."

And then we need to land this patch first (as PR41371 already covers the current behavior I think?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60825/new/

https://reviews.llvm.org/D60825





More information about the llvm-commits mailing list