[PATCH] D61011: [NFC] PHINode: introduce replaceIncomingBlockWith() function, use it

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 00:54:01 PDT 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1366
   for (PHINode &PN : LS.Header->phis())
-    for (unsigned i = 0, e = PN.getNumIncomingValues(); i < e; ++i)
-      replacePHIBlock(&PN, OldPreheader, Preheader);
----------------
This one is weird.
`replacePHIBlock()` would already iterate over every operand, so it's basically dead code i suppose.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61011/new/

https://reviews.llvm.org/D61011





More information about the llvm-commits mailing list