[PATCH] D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything

Fri Apr 26 00:25:28 PDT 2019

nikic added inline comments.

================
Comment at: test/Transforms/SimplifyCFG/X86/switch-covered-bug.ll:11
 ; are cached in PHIs.
 ; CHECK-LABEL: @test
 ; CHECK: entry:
----------------
Here and in the next file: You've generated new CHECK lines with update_test_checks, but the old ones are still there. These need to be manually dropped.

================
Comment at: test/Transforms/SimplifyCFG/switch-dead-default.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt %s -S -simplifycfg -O3 | FileCheck %s
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
Why the addition of `-O3` here? Generally tests in test/SimplifyCFG should use only `-simplifycfg`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61150/new/

https://reviews.llvm.org/D61150