[PATCH] D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header .

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 19:34:06 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/trunk/lib/Object/XCOFFObjectFile.cpp:40
+  llvm_unreachable("Not yet implemented!");
+  return;
+}
----------------
`return;` can be deleted


================
Comment at: llvm/trunk/lib/Object/XCOFFObjectFile.cpp:52
+  llvm_unreachable("Not yet implemented!");
+  return Result;
+}
----------------
If you write `llvm_unreachable` (`__builtin_unreachable()` or `__assume(false)`), an return statement can be omitted.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59419/new/

https://reviews.llvm.org/D59419





More information about the llvm-commits mailing list