[PATCH] D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:314
+int32_t XCOFFObjectFile::getSymbolTableOffset() const {
+  return FileHdrPtr->SymbolTableOffset;
+}
----------------
The field being returned is unsigned. The return type does not match.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:329
+uint32_t XCOFFObjectFile::getFlags() const {
+  return FileHdrPtr->Flags;
+}
----------------
The field being returned is 16-bit. The return type does not match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60878/new/

https://reviews.llvm.org/D60878