[PATCH] D60617: MSan: handle llvm.lifetime.start intrinsic

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2573
+    if (AllocaSet.count(AI))
+      AllocaSet.erase(AI);
+    LifetimeStartList.push_back(std::make_pair(&I, AI));
----------------
What if AllocaInst is visited after all of its lifetime.start calls? I'm not 100% that this is impossible, and then this code will poison both allocainst and lifetime.start.

IMHO, the visitor should simply collect allocas and lifetimes, and then the finalization code can erase allocas  as it instruments their lifetime.starts.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60617/new/

https://reviews.llvm.org/D60617