[PATCH] D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 17:22:28 PDT 2019


hubert.reinterpretcast added a comment.

In D61016#1476442 <https://reviews.llvm.org/D61016#1476442>, @hubert.reinterpretcast wrote:

> The test updates make sense given the current Clang driver behaviour; however, I think there is a question as to whether the Clang driver should be updated to add `-lc++`, etc. as necessary when it "automatically" links in `compiler-rt` libraries with such dependencies.


Thanks @xingxue for the off-list discussion. I agree that the Clang driver behaviour is a larger design question over packaging that should be a separate discussion at a later time. I'm good with this change to the tests, but I'd like to see if the other reviewers have comments to add.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61016/new/

https://reviews.llvm.org/D61016





More information about the llvm-commits mailing list