[PATCH] D60095: [LLD][COFF] Early load PDB type server files

[Alexandre Ganea via Phabricator via llvm-commits]

aganea updated this revision to Diff 196643.
aganea marked 4 inline comments as done.
aganea retitled this revision from "[LLD][COFF] Move PDB type server loading from PDB.cp early into InputFiles.cpp and introduce PDBInputFile" to "[LLD][COFF] Early load PDB type server files".
aganea edited the summary of this revision.
aganea added a reviewer: mstorsjo.
aganea added a comment.

I simplfied the patch by moving the `PDBInputFile` behavior into the existing `TypeServerSource` class. This makes things more elegant and keeps everything related to debug types into one place.

Tested (check-lld) on three different configurations:

1. MSBuild + MSVC 15.9.11 with LLVM_ENABLE_ASSERTIONS on, in a Debug target, under Windows 10 1803.
2. Ninja + Clang 8.0 in a Release target, under Windows 10 1803.
3. Ninja + GCC 7.3 in a Release target, under WSL/Ubuntu 18.04.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60095/new/

https://reviews.llvm.org/D60095

Files:
  COFF/DebugTypes.cpp
  COFF/DebugTypes.h
  COFF/Driver.cpp
  COFF/Driver.h
  COFF/PDB.cpp
  test/COFF/Inputs/pdb-type-server-valid-signature.yaml
  test/COFF/pdb-type-server-invalid-signature.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60095.196643.patch
Type: text/x-patch
Size: 21546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190425/58f32c80/attachment.bin>