[llvm] r359195 - gn build: Make setting llvm_enable_dia_sdk=true work

[Nico Weber via llvm-commits]

Author: nico
Date: Thu Apr 25 07:53:53 2019
New Revision: 359195

URL: http://llvm.org/viewvc/llvm-project?rev=359195&view=rev
Log:
gn build: Make setting llvm_enable_dia_sdk=true work

If this is set, %INCLUDE% must contain ".../DIA SDK/include"
and %LIB% must contain ".../DIA SKD/lib/amd64" (assuming you're doing a
64-bit build).

Modified:
    llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
    llvm/trunk/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn?rev=359195&r1=359194&r2=359195&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn Thu Apr 25 07:53:53 2019
@@ -1,4 +1,5 @@
 import("//llvm/lib/Target/targets.gni")
+import("//llvm/lib/DebugInfo/PDB/enable_dia.gni")
 import("//llvm/triples.gni")
 import("//llvm/utils/gn/build/buildflags.gni")
 import("//llvm/utils/gn/build/libs/edit/enable.gni")
@@ -77,7 +78,6 @@ write_cmake_config("config") {
     "HAVE_CRASHREPORTERCLIENT_H=",
     "HAVE_DECL_FE_ALL_EXCEPT=1",
     "HAVE_DECL_FE_INEXACT=1",
-    "LLVM_ENABLE_DIA_SDK=",
     "LLVM_ENABLE_CRASH_DUMPS=",
     "HAVE_ERRNO_H=1",
     "HAVE_FCNTL_H=1",
@@ -297,6 +297,12 @@ write_cmake_config("config") {
     values += [ "HAVE_TERMINFO=" ]
   }
 
+  if (llvm_enable_dia_sdk) {
+    values += [ "LLVM_ENABLE_DIA_SDK=1" ]
+  } else {
+    values += [ "LLVM_ENABLE_DIA_SDK=" ]
+  }
+
   if (llvm_enable_zlib) {
     values += [ "LLVM_ENABLE_ZLIB=1" ]
   } else {

Modified: llvm/trunk/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn?rev=359195&r1=359194&r2=359195&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn Thu Apr 25 07:53:53 2019
@@ -113,6 +113,6 @@ static_library("PDB") {
       "DIA/DIASourceFile.cpp",
       "DIA/DIATable.cpp",
     ]
-    # FIXME: Link against the right diaguids.lib too.
+    libs =  [ "diaguids.lib" ]
   }
 }