[PATCH] D59787: [ARM] Implement TTI::getMemcpyCost

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer updated this revision to Diff 196632.
SjoerdMeijer added a comment.

Hi Dave, many thanks for taking a look!

> Can you explain why this is more than 6? I would imagine it would be something like 4; 1 (for the call) + a few for argument setup.

6 was arbitrary, I wanted to make it slightly more costly than 'TCC_Expensive', but don't have good reasons at the moment, so I've changed it back to 4.

> Does this need to be clang-formatted?

I did and made a few changes. But to keep the inline comments near the arguments readable, I kept them on separate lines (clang-format puts them after each other).

> Is it worth adding a few strict-align tests too?

Yes, thanks for the suggestion. Done!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59787/new/

https://reviews.llvm.org/D59787

Files:
  lib/Analysis/TargetTransformInfo.cpp
  lib/Target/ARM/ARMTargetTransformInfo.cpp
  lib/Target/ARM/ARMTargetTransformInfo.h
  test/Analysis/CostModel/ARM/memcpy.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59787.196632.patch
Type: text/x-patch
Size: 17661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190425/632da17e/attachment.bin>