[PATCH] D59687: [DebugInfo] Prologue inserter need to insert DW_OP_deref_size

[Markus Lavin via Phabricator via llvm-commits]

markus updated this revision to Diff 196615.
markus added a comment.

After studying the reproducer and reading some in https://llvm.org/docs/SourceLevelDebugging.html I realize that maybe `isImplicit()` is not a sufficient condition and that we also need to include the second operand of the `DBG_VALUE` in the test.

Cant say that I am very sure about this though but at least it does solve the reported problem..

Any feedback is welcome!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59687/new/

https://reviews.llvm.org/D59687

Files:
  include/llvm/IR/DebugInfoMetadata.h
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/MIRParser/MIParser.cpp
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/IR/DebugInfoMetadata.cpp
  test/CodeGen/X86/prologepilog_deref_size.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59687.196615.patch
Type: text/x-patch
Size: 10407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190425/b6a20d6f/attachment.bin>