[PATCH] D61092: [llvm-strip] Have --discard-all imply --strip-debug

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 02:15:41 PDT 2019


grimar added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/discard-all-debug.test:2
+# RUN: cp %p/Inputs/dwarf.dwo %t
+# RUN: llvm-strip --keep-symbol=.L.str --discard-all %t
+# RUN: llvm-readobj --file-headers --sections %t | FileCheck %s
----------------
When I call GNU strip, it works without `--keep-symbol=.L.str` for this input.
Do you know why whe have a difference here?


================
Comment at: test/tools/llvm-objcopy/ELF/discard-all-debug.test:29
+CHECK-NOT:    Name: .rela.debug_line
+CHECK:    Name: .strtab
----------------
Seems instead of lines 3-29 all you really need is just this line:

```
# RUN: llvm-readobj --sections %t | FileCheck %s --implicit-check-not=.debug_
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61092/new/

https://reviews.llvm.org/D61092





More information about the llvm-commits mailing list