[PATCH] D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 02:14:16 PDT 2019


ostannard added inline comments.


================
Comment at: test/CodeGen/ARM/fp16-vector-argument.ll:31
+; HARD:       @ %bb.0: @ %entry
+; HARD-NEXT:    vmov d16, r0, r1
+; HARD-NEXT:    vabs.f16 d16, d16
----------------
This test is labelled as hard-float, but is passing the vector argument in GPRs. I suspect that this is because the APCS calling convention doesn't support hard-float. Actually, i think you could remove all of the tests for APCS to simplify this file, because it's a very old calling convention, which was superseded by AAPCS a long time ago, and it's unlikely to ever be used with v8.2A.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60720/new/

https://reviews.llvm.org/D60720





More information about the llvm-commits mailing list