[PATCH] D61065: [JITLink] Pass ObjectFile in NotifyLoaded() for JITEventListener support

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 15:24:26 PDT 2019


lhames added a comment.

This looks good, but I think we should hand back ownership of the MemoryBuffer instead, and drop the ObjectFile: The MemoryBuffer start address can serve as a stable key, and the ObjectFile can be re-created from the buffer if the client requires. This will allow us to avoid any coupling between JITLink's interface and libObject's, which will make refactoring easier when we want to move JITLink on to a libObject successor (which I think we will eventually).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61065/new/

https://reviews.llvm.org/D61065





More information about the llvm-commits mailing list