[PATCH] D60966: [WebAssembly] Emit br_table for most switch instructions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 12:31:31 PDT 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:277
+  // defer possible jump table optimizations to the VM.
+  setMinimumJumpTableEntries(2);
 }
----------------
dschuff wrote:
> Might be worth putting a TODO in here or somewhere to investigate using if/else instead once we have support for that?
In [[ https://bugs.llvm.org/show_bug.cgi?id=41502 | PR41502 ]], @kripken said using if/else generates bigger code too. If we are doing this for code size, do we need that TODO?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60966/new/

https://reviews.llvm.org/D60966





More information about the llvm-commits mailing list