[PATCH] D51133: win: Omit ".exe" from lld warning and error messages.

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added inline comments.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.


================
Comment at: lld/Common/Args.cpp:69
+
+StringRef lld::args::FilenameWithoutExe(StringRef path) {
+  if (sys::path::extension(path).equals_lower(".exe"))
----------------
grimar wrote:
> ruiu wrote:
> > path -> Path
> Should not function name start from the lower case? I would also add `get` prefix: `getFilenameWithoutExe`.
> This would be consistent with other functions around at least.
> 
> 
Sorry, I didn't see this for a few months. Looks like Rui took care for it in http://reviews.llvm.org/rL340716 though. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51133/new/

https://reviews.llvm.org/D51133