[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory

Kévin Petit via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 23:05:49 PDT 2019


kpet added a comment.

The implementation of `getFlatAddressSpace` in the AMDGPU backend does a bit more than just return a constant. This logic would need to be duplicated or the TTI called from their pass factory which would be the first use. TBH, I'm not too worried about the change to the factory breaking. This will be used in an out-of-tree project that tracks llvm fairly closely. If this breaks, I'll propose a change to exercise this from some in-tree code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60602/new/

https://reviews.llvm.org/D60602





More information about the llvm-commits mailing list