[PATCH] D61049: Let llvm-cvtres (and lld-link) report duplicate resources

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM

I guess it's better to keep tests standalone and not use llvm-rc for the input to the test here.



================
Comment at: llvm/test/tools/llvm-cvtres/duplicate.test:11
+RUN: cp %S/Inputs/id.res %t.dir/id2.res
+RUN: not llvm-cvtres /machine:X86 %t.dir/id1.res %t.dir/id2.res 2>&1 | \
+RUN:     FileCheck -check-prefix=ID %s
----------------
What output file does this write into? A temporary file that is removed afterwards - in what directory? (Would it be better to pass a named `-out:%t.obj` to make sure it doesn't do stray writes outside of the designated directory?)


================
Comment at: llvm/tools/llvm-cvtres/llvm-cvtres.cpp:105
   if (InputArgs.hasArg(OPT_HELP)) {
-    T.PrintHelp(outs(), "llvm-cvtres [options] file...", "Resource Converter", false);
+    T.PrintHelp(outs(), "llvm-cvtres [options] file...", "Resource Converter");
     return 0;
----------------
What does this particular changed line do, with respect to the rest of the patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61049/new/

https://reviews.llvm.org/D61049