[PATCH] D61011: [NFC] PHINode: introduce changeIncomingBlock() function, use it

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 22:05:19 PDT 2019


craig.topper added inline comments.


================
Comment at: include/llvm/IR/Instructions.h:2742
+  /// Change every incoming basic block \p Old to basic block \p New.
+  void changeIncomingBlock(BasicBlock *Old, BasicBlock *New) {
+    assert(New && Old && "PHI node got a null basic block!");
----------------
Would 'replace' be more consistent with other functions than 'change'? And I think we often include 'With' at the end for methods like this. For example User::replaceUsesOfWith


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61011/new/

https://reviews.llvm.org/D61011





More information about the llvm-commits mailing list