[PATCH] D60348: [COFF, ARM64] Fix ABI implementation of struct returns

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 16:31:08 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I went over other reviewers comments, and I think this was the only open one:

In D60348#1476017 <https://reviews.llvm.org/D60348#1476017>, @efriedma wrote:

> Is it possible to enable fast-isel and/or global-isel for ARM64 Windows?  Do we need additional code for them?  (I'm okay with making those changes separate patches, but it should be easy to at least add testcases now.)


Based on the comments in the test, I take it this will be addressed in a subsequent patch. Sounds good.

lgtm


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60348/new/

https://reviews.llvm.org/D60348





More information about the llvm-commits mailing list