[PATCH] D60227: [Remarks] Add string deduplication using a string table

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

LGTM



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1365
+  // just use the serialize function with a raw_ostream because of the way
+  // MCStreamers work.
+  const remarks::StringTable &StrTab = RS->getStringTable();
----------------
thegameg wrote:
> JDevlieghere wrote:
> > Can you be more specific? Could we write everything but the version to a buffer and EmitBinaryData here?
> Yes, we could, but we would perform an extra copy of the strings which this allows us to avoid.
Fair!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60227/new/

https://reviews.llvm.org/D60227