[PATCH] D61025: Add an optional arg to include/exclude synthetic profile when query hasProfileData

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 11:35:15 PDT 2019


eraman accepted this revision.
eraman added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/IR/Function.h:310
+    auto EC = getEntryCount();
+    if (!EC.hasValue() || (EC.isSynthetic() && !IncludeSynthetic))
+      return false;
----------------
To me
return EC.hasValue() && (IncludeSynthetic || !EC.isSynthetic()) looks cleaner and readable, but I'll leave it to you. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61025/new/

https://reviews.llvm.org/D61025





More information about the llvm-commits mailing list