[PATCH] D60952: [ConstantRange] Add urem support

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 11:04:52 PDT 2019


lebedev.ri added a comment.

In D60952#1475914 <https://reviews.llvm.org/D60952#1475914>, @nikic wrote:

> In D60952#1475582 <https://reviews.llvm.org/D60952#1475582>, @lebedev.ri wrote:
>
> > Even in the cases where we can't test that exhaustive test produces identical results,
> >  we should be able to at least test that `ConstantRange` is conservatively correct,
> >  in the sense that `ConstantRange` returns a superset of the exhaustive test, no?
>
>
> Yup. I've extended TestUnsignedBinOpExhaustive to support checking correctness only and used it here.


Great, thank you!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60952/new/

https://reviews.llvm.org/D60952





More information about the llvm-commits mailing list