[PATCH] D58578: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms.

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.

Overall changes: LGTM, thanks!

As already noted, I would probably change the is_valid_apple_platform to:
`is_apple_platform` -> just yes/no, even for the empty string.
or rename to `assert_valid_apple_platform()` -> no return value, aborts if not.

An `is_xxx` "getter" having 3 kinds of "results": true, false, or abort; is unexpected to me.
I don't feel too strongly strongly about this though, so land this at your discretion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58578/new/

https://reviews.llvm.org/D58578