[PATCH] D60970: [BlockExtractor] Change the basic block separator from ',' to ';'

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet created this revision.
qcolombet added a reviewer: volkan.
Herald added a project: LLVM.

This change aims at making the file format be compatible with the
way LLVM handles command line options.


Repository:
  rL LLVM

https://reviews.llvm.org/D60970

Files:
  lib/Transforms/IPO/BlockExtractor.cpp
  test/Transforms/BlockExtractor/extract-blocks-with-groups.ll


Index: test/Transforms/BlockExtractor/extract-blocks-with-groups.ll
===================================================================
--- test/Transforms/BlockExtractor/extract-blocks-with-groups.ll
+++ test/Transforms/BlockExtractor/extract-blocks-with-groups.ll
@@ -1,8 +1,8 @@
 ; Extract the 'if', 'then', and 'else' blocks into the same function.
-; RUN: echo 'foo if,then,else' > %t
+; RUN: echo 'foo if;then;else' > %t
 ; Make sure we can still extract a single basic block
 ; RUN: echo 'foo end' >> %t
-; RUN: echo 'bar bb14,bb20' >> %t
+; RUN: echo 'bar bb14;bb20' >> %t
 ; RUN: opt -S -extract-blocks -extract-blocks-file=%t %s | FileCheck %s
 
 ; CHECK-LABEL: foo
Index: lib/Transforms/IPO/BlockExtractor.cpp
===================================================================
--- lib/Transforms/IPO/BlockExtractor.cpp
+++ lib/Transforms/IPO/BlockExtractor.cpp
@@ -94,7 +94,7 @@
     if (LineSplit.empty())
       continue;
     SmallVector<StringRef, 4> BBNames;
-    LineSplit[1].split(BBNames, ',', /*MaxSplit=*/-1,
+    LineSplit[1].split(BBNames, ';', /*MaxSplit=*/-1,
                        /*KeepEmpty=*/false);
     if (BBNames.empty())
       report_fatal_error("Missing bbs name");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60970.196096.patch
Type: text/x-patch
Size: 1205 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190422/1e645053/attachment.bin>