[PATCH] D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:295
+    std::map<std::string, std::string> &ParseableSwiftInterfaces,
+    std::function<void(const Twine &, const DWARFDie &)> ReportWarning,
+    bool InImportedModule = false) {
----------------
JDevlieghere wrote:
> Maybe we should just make this a member function instead of passing ReportWarning as a callback. 
I just experimented with that, but then we need to pass the DebugMapObject around, which isn't much nicer than a reportWarning function. The static function has the advantage of making explicit what is being modified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60642/new/

https://reviews.llvm.org/D60642