[PATCH] D60846: [ValueTracking] Improve isKnowNonZero for Ints

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 03:34:05 PDT 2019


nikic added a comment.

Looks good to me technically, I think it's only reasonable that integers and pointers are treated the same way here. Would like to have a second opinion though, maybe from @spatel?

It should be noted that the instsimplify cases here would also be simplified by either instcombine (presumably the dominating condition code there) or CVP. Is that possibly why this was not done before?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60846/new/

https://reviews.llvm.org/D60846





More information about the llvm-commits mailing list