[llvm] r358861 - gn build: Merge r358749

[Nico Weber via llvm-commits]

Author: nico
Date: Sun Apr 21 13:08:45 2019
New Revision: 358861

URL: http://llvm.org/viewvc/llvm-project?rev=358861&view=rev
Log:
gn build: Merge r358749

Since the symlinks list for llvm-symbolizer is now never empty,
the :symlinks target no longer needs an explicit dep on :llvm-symbolizer
-- there will be at least one dep on a symlink, and each symlink depends
on :llvm-symbolizer already.

Since llvm-symbolizer:symlinks now produces symlinks that check-llvm
uses, make llvm/test depend on the symlink target.

Modified:
    llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn
    llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
    llvm/trunk/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn?rev=358861&r1=358860&r2=358861&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/test/BUILD.gn Sun Apr 21 13:08:45 2019
@@ -227,7 +227,7 @@ group("test") {
     "//llvm/tools/llvm-size",
     "//llvm/tools/llvm-split",
     "//llvm/tools/llvm-strings",
-    "//llvm/tools/llvm-symbolizer",
+    "//llvm/tools/llvm-symbolizer:symlinks",
     "//llvm/tools/llvm-undname",
     "//llvm/tools/llvm-xray",
     "//llvm/tools/lto",

Modified: llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn?rev=358861&r1=358860&r2=358861&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn Sun Apr 21 13:08:45 2019
@@ -11,7 +11,7 @@ if (llvm_install_binutils_symlinks) {
   }
 }
 
-# //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
+# //:llvm-objdump depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
   deps = [
     ":llvm-objdump",

Modified: llvm/trunk/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn?rev=358861&r1=358860&r2=358861&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn Sun Apr 21 13:08:45 2019
@@ -1,23 +1,25 @@
 import("//llvm/tools/binutils_symlinks.gni")
 import("//llvm/utils/gn/build/symlink_or_copy.gni")
 
+symlinks = [ "llvm-addr2line" ]
 if (llvm_install_binutils_symlinks) {
-  symlink_or_copy("addr2line") {
+  symlinks += [ "addr2line" ]
+}
+foreach(target, symlinks) {
+  symlink_or_copy(target) {
     deps = [
       ":llvm-symbolizer",
     ]
     source = "llvm-symbolizer"
-    output = "$root_out_dir/bin/addr2line"
+    output = "$root_out_dir/bin/$target"
   }
 }
 
 # //:llvm-symbolizer depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
-  deps = [
-    ":llvm-symbolizer",
-  ]
-  if (llvm_install_binutils_symlinks) {
-    deps += [ ":addr2line" ]
+  deps = []
+  foreach(target, symlinks) {
+    deps += [ ":$target" ]
   }
 }