[PATCH] D60854: [DAGLegalize][PowerPC] Add promote legalization of addc/adde and subc/sube

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 19 11:08:17 PDT 2019


efriedma added a comment.

> In former condition, such transformation is acceptable even operation ADDE is illegal and it only cares about type legality because illegal operation will be legalized later in DAG legalization phase

Generally, yes, before operation legalization we can create illegal operations.

ADDE is sort of an exception, though; we don't have operation legalization support for it, and we don't want to add it.  So the condition for the DAGCombine should be fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60854/new/

https://reviews.llvm.org/D60854





More information about the llvm-commits mailing list