[PATCH] D60870: POC. [PassBuilder] introduce a separate pass-pipeline parsing API

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

IMO it makes sense to separate parsing of the pipeline text and the pipeline tree more. Parsing the pipeline string into the tree of pipeline elements is an operation that happens once and as the very first thing, after which the string is not needed anymore. The PassBuilder could do that part, and then call the PipelineParser to further parse the tree. Otherwise this looks great!



================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:85
+
+    friend class PassBuilder;
+
----------------
Inner classes are auto-friends, are they not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60870/new/

https://reviews.llvm.org/D60870