[PATCH] D60858: AMDGPU: Skip debug instructions in assert

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 13:44:53 PDT 2019


arsenm added a comment.

In D60858#1472184 <https://reviews.llvm.org/D60858#1472184>, @echristo wrote:

> Looks ok to me. Are you worried about the correctness of the code? That seems to be a lot of matching?


It's just the autogenerated checks, which check everything. I'm worried about something changing whenever I get around to fixing the long branch expansion, and matching all of the long branch blocks is pretty annoying.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60858/new/

https://reviews.llvm.org/D60858





More information about the llvm-commits mailing list