[PATCH] D60885: [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC]

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 13:16:00 PDT 2019


sfertile created this revision.
sfertile added a reviewer: DiggerLin.
Herald added subscribers: jsji, hiraditya.
Herald added a project: LLVM.

Removes a number of includes where the included file was either not needed, or already included from ObjectFile.h


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60885

Files:
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/include/llvm/ObjectYAML/XCOFFYAML.h
  llvm/lib/Object/XCOFFObjectFile.cpp


Index: llvm/lib/Object/XCOFFObjectFile.cpp
===================================================================
--- llvm/lib/Object/XCOFFObjectFile.cpp
+++ llvm/lib/Object/XCOFFObjectFile.cpp
@@ -11,11 +11,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Object/XCOFFObjectFile.h"
-#include "llvm/ADT/ArrayRef.h"
-#include "llvm/Support/BinaryStreamReader.h"
-#include "llvm/Support/Endian.h"
-#include "llvm/Support/ErrorHandling.h"
-#include "llvm/Support/MathExtras.h"
 #include <cstddef>
 #include <cstring>
 
Index: llvm/include/llvm/ObjectYAML/XCOFFYAML.h
===================================================================
--- llvm/include/llvm/ObjectYAML/XCOFFYAML.h
+++ llvm/include/llvm/ObjectYAML/XCOFFYAML.h
@@ -13,7 +13,6 @@
 #define LLVM_OBJECTYAML_XCOFFYAML_H
 
 #include "llvm/ObjectYAML/YAML.h"
-#include <cstdint>
 
 namespace llvm {
 namespace XCOFFYAML {
Index: llvm/include/llvm/Object/XCOFFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/XCOFFObjectFile.h
+++ llvm/include/llvm/Object/XCOFFObjectFile.h
@@ -13,22 +13,7 @@
 #ifndef LLVM_OBJECT_XCOFFOBJECTFILE_H
 #define LLVM_OBJECT_XCOFFOBJECTFILE_H
 
-#include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/iterator_range.h"
-#include "llvm/BinaryFormat/Magic.h"
-#include "llvm/MC/SubtargetFeature.h"
-#include "llvm/Object/Binary.h"
-#include "llvm/Object/Error.h"
 #include "llvm/Object/ObjectFile.h"
-#include "llvm/Object/SymbolicFile.h"
-#include "llvm/Support/Casting.h"
-#include "llvm/Support/Error.h"
-#include "llvm/Support/FileSystem.h"
-#include "llvm/Support/MemoryBuffer.h"
-#include <cassert>
-#include <cstdint>
-#include <memory>
-#include <system_error>
 
 namespace llvm {
 namespace object {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60885.195805.patch
Type: text/x-patch
Size: 1800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190418/68fd59e1/attachment.bin>


More information about the llvm-commits mailing list