[PATCH] D60882: [WebAssembly] Error on relocations against undefined data symbols.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 11:45:15 PDT 2019


sbc100 created this revision.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google, dschuff.
Herald added a project: LLVM.

We can't meaningfully resolve certain types of relocations against
undefined data symbols.  Previously when `--allow-undefined` was used
we were treating such relocation much like weak data symbols and
simply inserting zeros.  This change turns such use cases in to an
error.

This means that `--allow-undefined` is no longer effective for data
symbols.

Fixes https://bugs.llvm.org/show_bug.cgi?id=40364


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60882

Files:
  lld/test/wasm/undefined-data.ll
  lld/wasm/InputFiles.cpp
  lld/wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60882.195794.patch
Type: text/x-patch
Size: 3918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190418/3033b219/attachment.bin>


More information about the llvm-commits mailing list